Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG: Update release date for v3.5.16 #18573

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Sep 10, 2024

Updated 3.5 CHANGELOG to reflect today's release.

Part of #18485.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (4997a2b) to head (843db04).

Current head 843db04 differs from pull request most recent head 96e17d3

Please upload reports for the commit 96e17d3 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 14 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18573      +/-   ##
==========================================
- Coverage   68.89%   68.83%   -0.06%     
==========================================
  Files         420      420              
  Lines       35474    35474              
==========================================
- Hits        24439    24420      -19     
- Misses       9621     9635      +14     
- Partials     1414     1419       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4997a2b...96e17d3. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Sep 10, 2024

/retest

@k8s-ci-robot
Copy link

@ivanvc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-govulncheck 96e17d3 link true /test pull-etcd-govulncheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ivanvc
Copy link
Member Author

ivanvc commented Sep 10, 2024

Expected failure. Refer to: #18548 (comment)

@jmhbnz jmhbnz merged commit c7b536c into etcd-io:main Sep 10, 2024
43 of 44 checks passed
@ivanvc ivanvc deleted the update-release-3.5.16-release-date branch September 10, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants